[#2480] Add NLDS paragraph components #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
force-pushed
the
feature/2480-add-NLDS-paragraphs
branch
2 times, most recently
from
4f0d754 to
fffc00d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1215 +/- ##
========================================
Coverage 95.22% 95.22%
========================================
Files 968 968
Lines 35249 35249
========================================
Hits 33566 33566
Misses 1683 1683 ☔ View full report in Codecov by Sentry. |
jiromaykin
force-pushed
the
feature/2480-add-NLDS-paragraphs
branch
5 times, most recently
from
702c0f2 to
29aaf04
Compare
jiromaykin
commented
May 28, 2024
|
@Bartvaderkin and @pi-sigma : So here is another fun big changes NLDS thing. This time I'm using the proper way to style 'modifiers' like |
jiromaykin
force-pushed
the
feature/2480-add-NLDS-paragraphs
branch
from
29aaf04 to
63f119f
Compare
pi-sigma
requested changes
May 29, 2024
src/open_inwoner/components/templates/components/Card/RenderCard.html
Outdated
Show resolved
Hide resolved
src/open_inwoner/components/templates/components/Messages/Messages.html
Outdated
Show resolved
Hide resolved
|
Adding 1.17.2 tag but considering the amount of work left I'm not sure if that is applicable |
jiromaykin
force-pushed
the
feature/2480-add-NLDS-paragraphs
branch
2 times, most recently
from
e87ff02 to
1f02c18
Compare
jiromaykin
force-pushed
the
feature/2480-add-NLDS-paragraphs
branch
2 times, most recently
from
e528595 to
3906b21
Compare
pi-sigma
requested changes
May 31, 2024
jiromaykin
force-pushed
the
feature/2480-add-NLDS-paragraphs
branch
from
3906b21 to
674573f
Compare
pi-sigma
approved these changes
Jun 3, 2024
swrichards
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2480
paragraph modifiers that Utrecht doesn't have are:
--compact,--small,--muted,--centeredThis means we will have to make "
--oip" modifiers with our own designtokens, so that municipalities that do not wish to use our design-tokens can use either their own or add custom-styling themselves.HTML example of the proper way of working:
This is what it looked/looks like in the past/legacy code:
<p class="p p--small">…..But now this should become:
<p class="utrecht-paragraph utrecht-paragraph--oip utrecht-paragraph--oip-small">.....We will not yet be implementing this for ALL
<p>tags because we have them in our own components that do not exist in NLDS at all. (Like the paragraphs inside the 'Mijn profiel' tabled sections for example).Also: in future I would love to completely remove all "legacy styling" that's meant to keep things backwards compatible for now. Plus it seems we have unused code, like
location-card-listwhich might be safe to delete but not sure. So 'clean-up' will need to become a separate issue.This PR relies on changes in our NLDS token package PR nr.9 so to view and check to see if all styles look the same, do an NPM ci --legacy-peer-deps install and rebuild.
Note to self: the two unique classes
utrecht-paragraph--oip-title-textandutrecht-paragraph--oip-summaryare not in design tokens becasue they should probably be defined by their parent component (like "readmore" component.